Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote:
> This patch makes the needlessly global mtdpart_setup() static.
> 
> @@ -346,7 +346,7 @@
>   *
>   * This function needs to be visible for bootloaders.
>   */
> -int mtdpart_setup(char *s)
> +static int mtdpart_setup(char *s)
>  {
>  	cmdline = s;
>  	return 1;

Jarkko,

You're recorded as submitting the original patch to make this
non-static:
http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/[email protected]?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c

Is this change correct?

If so, it should also delete the "needs to be visible" comment.

-andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
  - From: Jarkko Lavinen <[email protected]>

References:
- [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
  - From: Adrian Bunk <[email protected]>
- Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
  - From: David Woodhouse <[email protected]>

Prev by Date: Re: is there any Hard-disk shock-protection for 2.6.18 and above?
Next by Date: Re: Reserving a fixed physical address page of RAM.
Previous by thread: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
Next by thread: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]