Re: [PATCH -mm] x86_64 UP needs smp_call_function_single

On Wed, 2006-11-29 at 23:54 -0800, Andrew Morton wrote:
> which is somewhat unpleasant.  I added a WARN_ON(irqs_disabled()) to
> the
> out-of-line SMP version.

ok.
> 
> btw, does anyone know why the SMP versions of this function use
> spin_lock_bh(&call_lock)?

that makes no sense (neither the get_cpu()/put_cpu() gymnastics) if this
is called with irqs disabled all the time.

	Ingo
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH -mm] x86_64 UP needs smp_call_function_single
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] rtc: ds1743 support
• Next by Date: [PATCH] ppc: m48t35 add missing bracket
• Previous by thread: Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
• Next by thread: Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]