Re: [PATCH -mm] char: drivers use/need PCI

[Randy Dunlap <randy.dunlap@oracle.com>]

Jiri Slaby wrote:
> Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > With CONFIG_PCI=n:
> > drivers/char/mxser_new.c: In function 'mxser_release_res':
> > drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region'
> > drivers/char/mxser_new.c: In function 'mxser_probe':
> > drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region'
> > drivers/built-in.o: In function `sx_remove_card':
> > sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region'
> > drivers/char/isicom.c: In function 'isicom_probe':
> > drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region'
> > drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >  drivers/char/Kconfig |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > --- linux-2.6.19-rc6-mm2.orig/drivers/char/Kconfig
> > +++ linux-2.6.19-rc6-mm2/drivers/char/Kconfig
> > @@ -203,7 +203,7 @@ config MOXA_SMARTIO
> >  
> >  config MOXA_SMARTIO_NEW
> >  	tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
> > -	depends on SERIAL_NONSTANDARD
> > +	depends on SERIAL_NONSTANDARD && PCI
> >  	help
> >  	  Say Y here if you have a Moxa SmartIO multiport serial card and/or
> >  	  want to help develop a new version of this driver.
> > @@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
> >  
> >  config ISI
> >  	tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
> > -	depends on SERIAL_NONSTANDARD
> > +	depends on SERIAL_NONSTANDARD && PCI
> >  	select FW_LOADER
> >  	help
> >  	  This is a driver for the Multi-Tech cards which provide several
> > @@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
> >  
> >  config SX
> >  	tristate "Specialix SX (and SI) card support"
> > -	depends on SERIAL_NONSTANDARD
> > +	depends on SERIAL_NONSTANDARD && PCI
> >  	help
> >  	  This is a driver for the SX and SI multiport serial cards.
> >  	  Please read the file <file:Documentation/sx.txt> for details.
>
> Nack. I have to correct the mxser and sx code. Thanks,

Sure, either way is OK.  Thanks.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/