Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"

Matthew Wilcox wrote:

On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:

+#include "scsi_transport_api.h"

scsi_transport_api.h is a weird little file.  It's not included by
anything in the drivers/scsi directory, only
drivers/scsi/libsas/sas_scsi_host.c:#include "../scsi_transport_api.h"
drivers/ata/libata-eh.c:#include "../scsi/scsi_transport_api.h"

To me, that says it should be living in include/scsi/ somewhere ...
maybe just put the one function prototype into scsi_eh.h?

would it only go in include/scsi if it intends to be an exported
api for LLDD's and/or user apps ?  and stay in drivers/scsi if its
an internal api within the scsi subsystem itself ?

Based on who uses it, I would say its internal right now.

-- james s
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
    • From: Matthew Wilcox <[email protected]>

• References:
  • [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
    • From: Adrian Bunk <[email protected]>
  • Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
    • From: Matthew Wilcox <[email protected]>

• Prev by Date: make oldconfig problem Re: autoconf.h and auto.conf missing
• Next by Date: Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
• Previous by thread: Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
• Next by thread: Re: [2.6 patch] drivers/scsi/scsi_error.c should #include "scsi_transport_api.h"
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]