[PATCH] Don't compare unsigned variable for <0 in sys_prctl()

In kernel/sys.c::sys_prctl() the argument named 'arg2' is very clearly 
of type 'unsigned long', and when compiling with "gcc -W" gcc also warns :
  kernel/sys.c:2089: warning: comparison of unsigned expression < 0 is always false

So this patch removes the test of "arg2 < 0".

For those of us who compile their kernels with "-W" this gets rid of an 
annoying warning. For the rest of you it saves a few bytes of source code ;-)


Signed-off-by: Jesper Juhl <[email protected]>
---

diff --git a/kernel/sys.c b/kernel/sys.c
index 98489d8..086ea37 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -2086,7 +2086,7 @@ asmlinkage long sys_prctl(int option, un
 			error = current->mm->dumpable;
 			break;
 		case PR_SET_DUMPABLE:
-			if (arg2 < 0 || arg2 > 1) {
+			if (arg2 > 1) {
 				error = -EINVAL;
 				break;
 			}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Friends dont let friends use GCC -W (was Re: [PATCH] Don't compare unsigned
    • From: [email protected]
  • Re: [PATCH] Don't compare unsigned variable for <0 in sys_prctl()
    • From: Linus Torvalds <[email protected]>

• Prev by Date: [PATCH 2/2] joystick/analog: force HWEIGHT for module
• Next by Date: Re: [RFC: 2.6 patch] remove the broken MTD_PCMCIA driver
• Previous by thread: [PATCH 2/2] joystick/analog: force HWEIGHT for module
• Next by thread: Re: [PATCH] Don't compare unsigned variable for <0 in sys_prctl()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]