[PATCH] IDE: typo in ide-io.c leads to faulty assignment

Due to a typo in ide_start_power_step, the result of a function rather
than its pointer is assigned to args->handler. The patch applies to
2.6.19-rc6 but the problem exists in the stable branch as well.

Signed-off-by: Elias Oltmanns <[email protected]>
---

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 2614f41..48a249d 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -213,7 +213,7 @@ static ide_startstop_t ide_start_power_s
 	case idedisk_pm_idle:		/* Resume step 2 (idle) */
 		args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
 		args->command_type = IDE_DRIVE_TASK_NO_DATA;
-		args->handler = task_no_data_intr;
+		args->handler = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
 	case ide_pm_restore_dma:	/* Resume step 3 (restore DMA) */

---

• Follow-Ups:
  • Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment
    • From: "Jesper Juhl" <[email protected]>
  • Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment
    • From: Alan <[email protected]>

• Prev by Date: 2.6.19-rc6-git10 new perfmon code base + libpfm + pfmon
• Next by Date: Re: [PATCH] Add debugging aid for memory initialisation problems
• Previous by thread: 2.6.19-rc6-git10 new perfmon code base + libpfm + pfmon
• Next by thread: Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]