Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation

Christoph Hellwig wrote:

On Mon, Nov 27, 2006 at 12:29:38PM -0000, Avi Kivity wrote:

 #ifdef __x86_64__
-	__set_efer(vcpu, sregs->efer);
+	kvm_arch_ops->set_efer(vcpu, sregs->efer);
 #endif

I think it would be much better to make ->set_efer a noop for 32bit,
and have different operation vectors for 32 vs 64 bit.

Okay. I'll submit an incremental patch as part of a larger cleanup I'm planning.

 #ifdef __x86_64__
-	__set_efer(vcpu, 0);
+	vmx_set_efer(vcpu, 0);
 #endif

Similarly vmx_set_efer should just become a noop on 32bit.

Ok.

--
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/38] KVM: Decouple Intel VT implementation from base kvm
    • From: Avi Kivity <[email protected]>
  • [PATCH 19/38] KVM: Make __set_efer() an arch operation
    • From: Avi Kivity <[email protected]>
  • Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation
• Next by Date: Re: [PATCH] fix "prev->state: 2 != TASK_RUNNING??" problem on SD/MMC card removal
• Previous by thread: Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation
• Next by thread: [PATCH 20/38] KVM: Make set_cr3() and tlb flushing arch operations
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]