Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c

On Mon, Nov 27, 2006 at 10:35:08AM +0100, Cornelia Huck wrote:
> From: Cornelia Huck <[email protected]>
> 
> Check the return value of device_register() in platform_bus_init().

I still say this is absolutely crazy.  If a bus does not get registered,
what happens to all the devices and drivers which are registered against
that bus?

I suspect that if this bus_register doesn't work, you'll see an oops
sooner or later.  So it might as well be a BUG_ON here.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c
    • From: Cornelia Huck <[email protected]>

• References:
  • [Patch 3/7] driver core fixes: device_register() retval check in platform.c
    • From: Cornelia Huck <[email protected]>

• Prev by Date: Re: [RFC: 2.6 patch] i386: always enable regparm
• Next by Date: Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
• Previous by thread: [Patch 3/7] driver core fixes: device_register() retval check in platform.c
• Next by thread: Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]