* Ingo Molnar <mingo@elte.hu> wrote: > > Hmm, that just won't do for PPC threaded fasteoi flows! What you'll > > get is a threaded IRQ with EOI *never ever* issued, unless my PPC > > patch is also in... > > ok, how about the patch below in addition? or rather, the one below. Untested. Ingo Index: linux/kernel/irq/chip.c =================================================================== --- linux.orig/kernel/irq/chip.c +++ linux/kernel/irq/chip.c @@ -392,11 +394,12 @@ handle_fasteoi_irq(unsigned int irq, str desc->status |= IRQ_INPROGRESS; /* - * In the threaded case we fall back to a mask+ack sequence: + * In the threaded case we fall back to a mask+eoi sequence: */ if (redirect_hardirq(desc)) { - mask_ack_irq(desc, irq); - goto out_unlock; + if (desc->chip->mask) + desc->chip->mask(irq); + goto out; } desc->status &= ~IRQ_PENDING; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- References:
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- From: Ingo Molnar <mingo@elte.hu>
- Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Prev by Date: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Next by Date: Re: path_lookup for executable
- Previous by thread: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Next by thread: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
- Index(es):
![]() |