Re: [PATCH]: first proposal for pci resume quirk interface

Hi!

Looks okay to me.


>  #define DECLARE_PCI_FIXUP_ENABLE(vendor, device, hook)			\
>  	DECLARE_PCI_FIXUP_SECTION(.pci_fixup_enable,			\
>  			vendor##device##hook, vendor, device, hook)
> +#define DECLARE_PCI_FIXUP_RESUME(vendor, device, hook)			\
> +	DECLARE_PCI_FIXUP_SECTION(.pci_fixup_resume,			\
> +			resume##vendor##device##hook, vendor, device, hook)

Maybe having DECLARE_PCI_FIXUP_ALWAYS (meaning ENABLE+RESUME)  would reduce the code
duplication?

-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH]: first proposal for pci resume quirk interface
    • From: Alan <[email protected]>

• References:
  • [PATCH]: first proposal for pci resume quirk interface
    • From: Alan <[email protected]>

• Prev by Date: Re: How to go about debuging a system lockup?
• Next by Date: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
• Previous by thread: [PATCH]: first proposal for pci resume quirk interface
• Next by thread: Re: [PATCH]: first proposal for pci resume quirk interface
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]