Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

[Chris Snook <csnook@redhat.com>]

Randy Dunlap wrote:
> On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:
>
> > From: Jay Cliburn <jacliburn@bellsouth.net>
> >
> > This patch contains the build files for the Attansic L1 gigabit ethernet
> > adapter driver.
> >
> > Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
> > ---
> >
> >  Kconfig       |   12 ++++++++++++
> >  Makefile      |    1 +
> >  atl1/Makefile |   30 ++++++++++++++++++++++++++++++
> >  3 files changed, 43 insertions(+)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 6e863aa..f503d10 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2329,6 +2329,18 @@ config QLA3XXX
> >  	  To compile this driver as a module, choose M here: the module
> >  	  will be called qla3xxx.
> >  
> > +config ATL1
> > +	tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
> > +	depends on NET_PCI && PCI && EXPERIMENTAL
> > +	select CRC32
> > +	select MII
> > +	---help---
> > +	  This driver supports Attansic L1 gigabit ethernet adapter.
> > +
> > +	  To compile this driver as a module, choose M here.  The module
> > +	  will be called atl1.
> > +
> > +
> >  endmenu
>
> One problem here is that MII depends on NET_ETHERNET, which is
> 10/100 ethernet, which may not be enabled if someone has only
> gigabit ethernet.  :)

I'm actually quite inclined to rip out all MII support entirely. 
There's a lot of code in this driver that needs cleaning up 
cosmetically, and removing deprecated features would certainly speed 
things up.  What do you think?

	-- Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/