reboot, not loop forever (Re: [PATCH 20/20] x86_64: Move CPU verification code to common file)

[Oleg Verych <olecom@flower.upol.cz>]

On Fri, Nov 17, 2006 at 11:32:59PM -0800, H. Peter Anvin wrote:
> Oleg Verych wrote:
> >On Fri, Nov 17, 2006 at 10:59:32PM -0800, H. Peter Anvin wrote:
> >>Oleg Verych wrote:
> >>>It will burn CPU, until power cycle will be done (my AMD64 laptop and
> >>>Intel's amd64 destop PC require that). In case of reboot timeout (or
> >>>just reboot with jump to BIOS), i will just choose another image to boot
> >>>or will press F8 to have another boot device.
> >>>
> >>That's a fairly stupid argument, since it assumes operator intervention, 
> >>at which point you have access to the machine anyway.
> >
> >I would never call *power cycle* stupid, just because from physics
> >point of veiw.
> >
> >Example. I have my flower.upol.cz many kilometers far away from me.
> >I used to boot it from that flash (new hardware, sata problems, etc).
> >
> >When something goes wrong with rc kernel or power source, bum.
> >And i had to move my ass there, just to press reset. Because.
> 
> Yes, and you would have to do that to press F8 too.

That peace of code used in many places, thus, i've mentioned F8, if
wrong kernel on wrong computer was launched.

> >While i have "power on, on AC failures" in BIOS, *sometimes* flash
> >will not boot (i don't know why, maybe it's GRUB+flash-read,
> >or BIOS usb hdd implementation specific).
> 
> I was making the point that there is unattended recovery possible.  That 
> makes it a significant argument.  That a user on a laptop has to wait 
> four seconds pushing the power button is not.

As additional note to Andi and many of you, who will say, that it's
a couple of asm instructions, just send patch.

I'm see many kinds of reboot functions in include/linux/reboot.h.
There even reboot_fixup.h. Some of them may be copy/pasted in place of
that while(1) loop, who knows which exactly? What problems it may cause?

I used to write PC bootloaders with tasm, when i was a child
(10 years ago). Nothing major, ok with that.

But i bet, i will spot whitespace and tabification issues in files,
i will visit with emacs and eventually making patches with that. First
ever try with top Makefile failed, this makefile have something after
tabification, that Andrew Morton's makefile (from FC5) doesn't like.
Funny. Don't call me bureaucrat, but this is (my) mater of *not* being
kind of dumb.

> 	-hpa

Thanks.

--
-o--=O`C  info emacs : not found  /. .\ (is there any reason to live?)
 #oo'L O  info make  : not found      o (           R.I.P            )
<___=E M  man gcc    : not found    .-- (  Debian Operating System   )

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/