On Sat, 18 Nov 2006 06:44:33 +0000 Oleg Verych <[email protected]> wrote: > > > On 2006-11-18, Stephen Rothwell wrote: > [] > >> --- linux-2.6.19-rc5-mm2.orig/kernel/exit.c 2006-11-15 16:48:11.485511089 -0600 > >> +++ linux-2.6.19-rc5-mm2/kernel/exit.c 2006-11-17 23:04:09.764530373 -0600 > >> @@ -48,6 +48,8 @@ > >> #include <asm/pgtable.h> > >> #include <asm/mmu_context.h> > >> > >> +extern kmem_cache_t *fs_cachep; > > > > You know what I am going to say, right? :-) > > I know, externs must be in headers. Please, explain why. So that there is only one declaration. That way if it is changed, everywhere that uses it will notice. Also, the same header must be included by the file that defines the variable or function so any discrepancy between declaration and definition will be obvious. i.e. we are protecting ourselves against change and making maintainance easier. In this particular case, the type is probably never going to change, but consistency is good. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpnj1jzFzlkm.pgp
Description: PGP signature
- References:
- [RFC 0/7] Remove slab cache declarations in slab.h
- From: Christoph Lameter <[email protected]>
- [RFC 6/7] Use an external declaration in exit.c for fs_cachep
- From: Christoph Lameter <[email protected]>
- Re: [RFC 6/7] Use an external declaration in exit.c for fs_cachep
- From: Stephen Rothwell <[email protected]>
- Re: [RFC 6/7] Use an external declaration in exit.c for fs_cachep
- From: Oleg Verych <[email protected]>
- [RFC 0/7] Remove slab cache declarations in slab.h
- Prev by Date: Re: [PATCH 18/20] x86_64: Relocatable kernel support
- Next by Date: Re: [PATCH 1/2] input: make serio_register_driver() return error code
- Previous by thread: Re: [RFC 6/7] Use an external declaration in exit.c for fs_cachep
- Next by thread: Re: [RFC 6/7] Use an external declaration in exit.c for fs_cachep
- Index(es):
 |