Re: [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse()

On Fri, Nov 17, 2006 at 11:54:04AM -0800, Andrew Morton wrote:
> On Fri, 17 Nov 2006 15:21:45 +0100
> Adrian Bunk <[email protected]> wrote:
> 
> > This patch removes the no longer used pci_find_device_reverse().
> 
> But it is exported to modules.
> 
> This is what we created EXPORT_UNUSED_SYMBOL() for.

Normally - but for the fact pci_find_device{_reverse} is unsafe on
any box with any kind of pci hotplug events.

It really needs to die. It is not hotplug safe. The alternative would be
to export it only with !CONFIG_HOTPLUG (which is what my test kernel
does for both this and pci_find_device()). If we do that then to all
intents and purposes it vanishes from most standard builds

The conversion is also trivial

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.19-rc5-mm2
    • From: Andrew Morton <[email protected]>
  • [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse()
    • From: Adrian Bunk <[email protected]>
  • Re: [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse()
    • From: Andrew Morton <[email protected]>

• Prev by Date: TTY layer locking design
• Next by Date: Re: [rfc patch] Re: sched: incorrect argument used in task_hot()
• Previous by thread: Re: [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse()
• Next by thread: Re: [-mm patch] remove drivers/pci/search.c:pci_find_device_reverse()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]