Re: [PATCH 3/3] KVM: Expose MSRs to userspace

On Fri, 17 Nov 2006 09:20:49 +0200
Avi Kivity <[email protected]> wrote:

> >> +out_vcpu:
> >> +	vcpu_put(vcpu);
> >> +
> >> +	return rc;
> >> +}
> >>     
> >
> > This function returns no indication of how many msrs it actually did set. 
> > Should it?
> >   
> 
> It can't hurt.  Is returning the number of msrs set in the return code 
> (ala short write) acceptable, or do I need to make this a read/write ioctl?
> 

I'd have thought that you'd just copy the number written into msrs->nmsrs via

	msrs->nmsrs = num_entries;

like kvm_dev_ioctl_set_msrs() does.  Dunno...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/3] KVM: Expose MSRs to userspace
    • From: Avi Kivity <[email protected]>

• References:
  • [PATCH 0/3] KVM: Save/resume support
    • From: Avi Kivity <[email protected]>
  • [PATCH 3/3] KVM: Expose MSRs to userspace
    • From: Avi Kivity <[email protected]>
  • Re: [PATCH 3/3] KVM: Expose MSRs to userspace
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 3/3] KVM: Expose MSRs to userspace
    • From: Avi Kivity <[email protected]>

• Prev by Date: Re: [PATCH] usb: generic calibration support
• Next by Date: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
• Previous by thread: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
• Next by thread: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]