Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???

On Thursday 16 November 2006 19:37, Herbert Xu wrote:
> David Miller <[email protected]> wrote:
> >
> > I'm very happy to accept a patch which assert's this using BUG()
> > checks :-)
> 
> A BUG() won't be necessary because the NULL pointer dereferences will
> OOPS anyway.
>

BUG()s there would be a mechanism to document invariants so next time
someone is looking at the code there are no questions.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???
  - From: Herbert Xu <[email protected]>

References:
- Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???
  - From: Herbert Xu <[email protected]>

Prev by Date: Re: [PATCH 09/13] Core WQE/CQE Types
Next by Date: m68knommu doesn't build upstream
Previous by thread: Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???
Next by thread: Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]