Re: [PATCH] ALSA: hda-intel - Disable MSI support by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Benjamin Herrenschmidt wrote:
On Tue, 2006-11-14 at 20:28 -0800, David Miller wrote:
From: Jeff Garzik <[email protected]>
Date: Tue, 14 Nov 2006 23:24:04 -0500

I can't answer for the spec, but at least two independent device vendors recommended to write an MSI driver that way (disable intx, enable msi).
Ok.

Completely independent of MSI though, a PCI 2.2 compliant driver should be nice and disable intx on exit, just to avoid any potential interrupt hassles after driver unload. And of course be aware that it might need to enable intx upon entry.
This also sounds like it should occur in the generic PCI layer when a
PCI driver is unregistered.

Is this disable_intx() thingy something x86 specific ? I mean, you can't
just call disable_irq() for LSIs since you can be sharing it. If you
aren't sharing, free_irq() will mask for you.

We are referring to the standard PCI 2.2 bit, PCI_COMMAND_INTX_DISABLE.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux