On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote: > > This is a non-urgent patch. > > I can't figure out who the upstream maintainer for char drivers > is supposed to be. Can this patch be applied? > > --linas > > This patch removes an pair of irritating compiler warnings: > > drivers/char/hvcs.c:1605: warning: ignoring return value of > sysfs_create_group declared with attribute warn_unused_result > drivers/char/hvcs.c:1639: warning: ignoring return value of > driver_create_file declared with attribute warn_unused_result > > Doing this required moving a big block of code from the bottom > of the file to the top, so as to avoid the need for (irritating) > forward declarations. Can you do the move and the fix as two patches? It's very hard to review in its current form. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: [PATCH]: HVCS char driver janitoring: fix compile warnings
- From: [email protected] (Linas Vepstas)
- Re: [PATCH]: HVCS char driver janitoring: fix compile warnings
- References:
- [PATCH]: HVCS char driver janitoring: fix compile warnings
- From: [email protected] (Linas Vepstas)
- [PATCH]: HVCS char driver janitoring: fix compile warnings
- Prev by Date: Re: Boot failure with ext2 and initrds
- Next by Date: [PATCH] cxgb3: Chelsio T3 1G/10G ethernet device driver
- Previous by thread: [PATCH]: HVCS char driver janitoring: fix compile warnings
- Next by thread: Re: [PATCH]: HVCS char driver janitoring: fix compile warnings
- Index(es):
 |