Re: [PATCH] Fix strange size check in __get_vm_area_node()

On Wednesday 15 November 2006 18:39, OGAWA Hirofumi wrote:
> Recently, __get_vm_area_node() was changed like following
>
>  	if (unlikely(!area))
>  		return NULL;
>
> -	if (unlikely(!size)) {
> -		kfree (area);
> +	if (unlikely(!size))
>  		return NULL;
> -	}
>
> It is leaking `area', also original code seems strange already.
> Probably, we wanted to do this patch.
>

Indeed. I checked my original patch and it was correct. I dont know what 
happened then...

http://lkml.org/lkml/2006/10/23/86

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix strange size check in __get_vm_area_node()
    • From: OGAWA Hirofumi <[email protected]>

• Prev by Date: [2.6.20 patch] the scheduled removal of some OSS options
• Next by Date: Re: [PATCH] i386-pda UP optimization
• Previous by thread: [PATCH] Fix strange size check in __get_vm_area_node()
• Next by thread: [PATCH -mm] fb: modedb uses wrong default_mode
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]