Jan Beulich writes:
> Pointers should not be casted to u32 as this results in compiler warnings
> on 64-bit platforms.
>
> Signed-off-by: Jan Beulich <[email protected]>
>
> --- linux-2.6.19-rc5/drivers/acpi/executer/exmutex.c 2006-09-20 05:42:06.000000000 +0200
> +++ 2.6.19-rc5-acpi-warnings/drivers/acpi/executer/exmutex.c 2006-11-06 09:10:16.000000000 +0100
> @@ -266,10 +266,10 @@ acpi_ex_release_mutex(union acpi_operand
> walk_state->thread->thread_id)
> && (obj_desc->mutex.os_mutex != ACPI_GLOBAL_LOCK)) {
> ACPI_ERROR((AE_INFO,
> - "Thread %X cannot release Mutex [%4.4s] acquired by thread %X",
> - (u32) walk_state->thread->thread_id,
> + "Thread %lX cannot release Mutex [%4.4s] acquired by thread %lX",
> + (unsigned long) walk_state->thread->thread_id,
> acpi_ut_get_node_name(obj_desc->mutex.node),
> - (u32) obj_desc->mutex.owner_thread->thread_id));
> + (unsigned long) obj_desc->mutex.owner_thread->thread_id));
> return_ACPI_STATUS(AE_AML_NOT_OWNER);
> }
>
> --- linux-2.6.19-rc5/drivers/acpi/utilities/utmutex.c 2006-09-20 05:42:06.000000000 +0200
> +++ 2.6.19-rc5-acpi-warnings/drivers/acpi/utilities/utmutex.c 2006-11-06 09:10:16.000000000 +0100
> @@ -258,8 +258,8 @@ acpi_status acpi_ut_acquire_mutex(acpi_m
> acpi_gbl_mutex_info[mutex_id].thread_id = this_thread_id;
> } else {
> ACPI_EXCEPTION((AE_INFO, status,
> - "Thread %X could not acquire Mutex [%X]",
> - (u32) this_thread_id, mutex_id));
> + "Thread %lX could not acquire Mutex [%X]",
> + (unsigned long) this_thread_id, mutex_id));
> }
>
> return (status);
NAK. Use "%p" for formatting pointers. No casts needed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
