On Wednesday, 15 November 2006 02:48, Benjamin Herrenschmidt wrote:
> On Wed, 2006-11-15 at 01:54 +0100, Christian Hoffmann wrote:
> > On Tuesday 14 November 2006 23:07, Benjamin Herrenschmidt wrote:
> > > > I tried that patch, but the last message I see over netconsole (using
> > > > tg3) is: Suspending console(s)
> > > > and then nothing. Nothing on resume at all :(
> > > >
> > > > Adding some printks in the radeonfb_pci_suspend and radeonfb_pci_resume
> > > > (radeon_pm.c) didn't help: I don't see them. But I am not a kernel
> > > > programmer at all, so I might do something wrong or in the wrong place.
> > >
> > > Does it resume if you make radeon_pci_resume() a nop ?
> > >
> > > Of course, the fbdev will not come back, but will the machine overall
> > > resume ?
> > >
> > > Ben.
> > Yes, if i make radeon_pci_resume a nop, the machine resumes if i do a return 0
> > immediately.
> > I think I tracked it down to the call to acquire_console_sem() as the
> > following code makes the machine hang again:
> >
> > int radeonfb_pci_resume(struct pci_dev *pdev)
> > {
> > struct fb_info *info = pci_get_drvdata(pdev);
> > struct radeonfb_info *rinfo = info->par;
> > int rc = 0;
> > if (pdev->dev.power.power_state.event == PM_EVENT_ON)
> > return 0;
> > if (rinfo->no_schedule) {
> > /* if (try_acquire_console_sem())*/
> > return 0;
> > } else
> > acquire_console_sem();
> >
> > return 0;
> > ...
>
> Well, if you acquire the console sem you need to release it too :-)
Or the console semaphore is acquired too many times.
Christian, could you please add release_console_sem() before 'return 0'
and see if that makes the code work again? If not, could you add a printk()
in kernel/printk.c/acquire_console_sem() to see how many times it is called?
Greetings,
Rafael
--
You never change things by fighting the existing reality.
R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
