On Mon, 2006-11-13 at 16:42 -0800, Andrew Morton wrote:
> pin = find_isa_irq_pin(8, mp_INT);
> + if (pin == -1) {
> + printk(KERN_ERR "unlock_ExtINT_logic:
> find_isa_irq_pin()
> + "failed\n");
> + return;
> + }
> apic = find_isa_irq_apic(8, mp_INT);
> - if (pin == -1)
> + if (apic == -1) {
> + printk(KERN_ERR "unlock_ExtINT_logic:
> find_isa_irq_apic()
> + "failed\n");
> return;
> + }
as i mentioned it in my mail yesterday, if find_isa_irq_apic() returns
-1 then find_isa_irq_pin() has to return -1 too. But this is obscure and
needs to be documented at least - and your patch is good for
documentation purposes too :-)
Acked-by: Ingo Molnar <[email protected]>
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
