Re: [PATCH 2/2] Use dev_sysdata for ACPI and remove firmware_data

[Len Brown <len.brown@intel.com>]

On Friday 10 November 2006 00:49, Greg KH wrote:
> On Thu, Nov 09, 2006 at 11:58:36AM +1100, Benjamin Herrenschmidt wrote:
> > This patch changes ACPI to use the new dev_sysdata on x86 and x86_64 (is there
> > any other arch using ACPI ?) to store it's acpi_handle. It also removes the
> > firmware_data field from struct device as this was the only user.
> 
> Yeah!  I've wanted to drop firmware_data for a while now :)

device.firmware_data was born when we went to link Linux devices
and ACPI devices using device.platform_data and found it was already used.
You recommended we create a new field to avoid the conflict, and
IIR the discussion suggested that eventually device.platform_data use
would get cleaned up and the fields could perhaps some day be combined.

I don't know if we are any closer to that day, before or after this change.

However, I'm fine with Ben's re-name -- it changes no functionality on ACPI-enabled
systems while potentially deleting an unused pointer/dev on other architectures.

Please ship his patch #2 along with patch #1 that it depends on.

Acked-by: Len Brown <len.brown@intel.com>

thanks
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/