Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h

> 
> I think we need these UL suffixes. Otherwise in some cases overflow
> can take place and compiler emits warning.
> 
> For ex. in following definition I got rid of UL.
> 
> #define PGDIR_SIZE      (1 << PGDIR_SHIFT) 

Yes for the shifts it is needed, but not for the unshifted constants.
I think. At least when they're hex the compiler should chose the right
type on its own.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h
    • From: [email protected] (Eric W. Biederman)

• References:
  • [RFC] [PATCH 0/16] x86_64: Relocatable bzImage Support (V2)
    • From: Vivek Goyal <[email protected]>
  • Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h
    • From: Andi Kleen <[email protected]>
  • Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h
    • From: Vivek Goyal <[email protected]>

• Prev by Date: Re: [PATCH 1/2] Make the TSC safe to be used by gettimeofday().
• Next by Date: Re: [PATCH 1/2] Make the TSC safe to be used by gettimeofday().
• Previous by thread: Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h
• Next by thread: Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]