On Mon, Nov 13, 2006 at 12:21:05PM -0700, Eric W. Biederman wrote:
> Andi Kleen <[email protected]> writes:
>
> >> This code (verify_cpu) is called while we are still in real mode. So it has
> >> to be present in low 1MB. Now in trampoline has been designed to switch to
> >> 64bit mode and then jump to the kernel hence kernel can be loaded anywhere
> >> even beyond (4G). So if we move this code into say arch/x86_64/kernel/head.S
> >> then we can't even call it.
> >
> > I didn't mean to call it. Just #include it from a common file
>
> I believe the duplication winds up happening in setup.S
>
Yes. So boot cpu code in setup.S is also doing these checks. So one
of the options is that I create a new file says verify_cpu.S and this
code can be shared by setup.S, trampoline.S and wakeup.S.
Or, I can simply drop the verify_cpu bit from trampoline.S and wakeup.S.
This looks like a non-essential bit and in the past we did not perform
these checks in trampoline.S and wakeup.S
At this point of time, I will prefer to go with second option of dropping
extended checks in trampoline.S and wakeup.S to keep things simple.
Does that make sense?
Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
