Re: [PATCH] Apple Motion Sensor driver

[Jean Delvare <khali@linux-fr.org>]

Hi Stelian,

On Sat, 11 Nov 2006 22:36:11 +0100, Stelian Pop wrote:
> This driver adds support for the Apple Motion Sensor (AMS) as found in 2005
> revisions of Apple PowerBooks and iBooks.  It implements both the PMU and
> I²C variants.  The I²C driver and mouse emulation is based on code by
> Stelian Pop <stelian@popies.net>, while the PMU driver has been developped
> by Michael Hanselmann <linux-kernel@hansmi.ch>. HD parking support will be
> added later.
> 
> Various people contributed fixes to this driver, including
> Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org> and
> Jean Delvare <khali@linux-fr.org>.
> 
> This patch lived for a while in the -mm tree but was dropped by Andrew in
> 2.6.18-mm1 because of some conflicting changes he was send at the time.
> Things have settled down since then, I merged all the bits and pieces and 
> rediffed against the latest git.
> 
> This driver should be quite mature to go directly into the input tree. If not,
> Andrew please pick it up again.
> 
> (...)
>  b/drivers/hwmon/ams/Makefile    |    8 +
>  b/drivers/hwmon/ams/ams-core.c  |  265 +++++++++++++++++++++++++++++++++++
>  b/drivers/hwmon/ams/ams-i2c.c   |  299 ++++++++++++++++++++++++++++++++++++++++
>  b/drivers/hwmon/ams/ams-mouse.c |  147 +++++++++++++++++++
>  b/drivers/hwmon/ams/ams-pmu.c   |  207 +++++++++++++++++++++++++++
>  b/drivers/hwmon/ams/ams.h       |   72 +++++++++
>  drivers/hwmon/Kconfig           |   25 +++
>  drivers/hwmon/Makefile          |    1 
>  8 files changed, 1024 insertions(+)

There's some confusion here. On the one hand, you placed your driver
in the hwmon directory, and integrated it in the Hardware Monitoring
menu. But on the other hand you seem to think that the input tree is
the natural merge path for this patch. Isn't it strange?

This raises the question of what these drivers (ams, hdaps...) really
are, and where they really belong. The hdaps driver is very different
from all other driver in the hwmon directory. Maybe they would be
better located in drivers/input/accel? This is an open question, I
really don't know.

(Side note: you could use the -p1 parameter of diffstat for better
results.)

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/