Ian Kent <[email protected]> wrote:
> - if (sbi->pipe) {
> - fput(sbi->pipe); /* Close the pipe */
> - sbi->pipe = NULL;
> - }
> + fput(sbi->pipe); /* Close the pipe */
> + sbi->pipe = NULL;
Ummm... Is that right? fput() doesn't check its argument for a NULL pointer,
so the original code shouldn't hurt and should give you an extra bit of
defense.
Other than that, it looks reasonable.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
