Re: [patch] fix up generic csum_ipv6_magic function prototype

Al Viro <[email protected]> writes:
> 
> Incidentally, WTF is
> define SK_CS_CALCULATE_CHECKSUM
> #ifndef CONFIG_X86_64
> #define SkCsCalculateChecksum(p,l)      ((~ip_compute_csum(p, l)) & 0xffff)
> #else
> #define SkCsCalculateChecksum(p,l)      ((~ip_fast_csum(p, l)) & 0xffff)   
> #endif
> in ./drivers/net/sk98lin/h/skdrv1st.h?

Looks totally bogus. The x86-64 ip_fast_csum is practically identical
to the i386 version. Someone must have been asleep while reviewing
that code.

But AFAIK sk98lin is scheduled for deletion anyways, to be replaced by 
sky*. Probably for good reasons. Hopefully soon.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch] fix up generic csum_ipv6_magic function prototype
    • From: "Chen, Kenneth W" <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: David Miller <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: Al Viro <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: David Miller <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: Al Viro <[email protected]>

• Prev by Date: Re: [patch 2/4] permission mapping for sys_syslog operations
• Next by Date: [PATCH 2.6.19-rc5-git2] EFI: mapping memory region of runtime services when using memmap kernel parameter
• Previous by thread: Re: [patch] fix up generic csum_ipv6_magic function prototype
• Next by thread: Re: [patch] fix up generic csum_ipv6_magic function prototype
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]