Re: [patch] fix up generic csum_ipv6_magic function prototype

On Mon, Nov 13, 2006 at 08:52:23AM +0000, Al Viro wrote:
> After doing the above we have the following:
> 
> Platform-dependent:
> __wsum csum_tcpudp_nofold(__be32, __be32, T1, T2, __wsum);
> On arm/arm26: T1 = unsigned short, T2 = unsigned int.
> __sum16 csum_tcpudp_magic(__be32, __be32, unsigned short, T, __wsum);
> On arm/arm26 T is unsigned int, elsewhere it's unsigned short.

Could both become unsigned short or unsigned int.  Would prefer
unsigned int on ARM, since otherwise the compiler generate code to
truncate any variable "int"s to an unsigned short.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: Al Viro <[email protected]>

• References:
  • [patch] fix up generic csum_ipv6_magic function prototype
    • From: "Chen, Kenneth W" <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: David Miller <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: Al Viro <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: David Miller <[email protected]>
  • Re: [patch] fix up generic csum_ipv6_magic function prototype
    • From: Al Viro <[email protected]>

• Prev by Date: Re: [patch] genapic: optimize & fix APIC mode setup
• Next by Date: [patch 0/4] Syslog permissions, revised
• Previous by thread: Re: [patch] fix up generic csum_ipv6_magic function prototype
• Next by thread: Re: [patch] fix up generic csum_ipv6_magic function prototype
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]