Re: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value

On Sun, 2006-11-12 at 18:48 +0100, Adrian Bunk wrote:
> The Coverity checker noted that bad things might happen if 
> find_isa_irq_apic() returned -1.
> 
> Signed-off-by: Adrian Bunk <[email protected]>

hm, it seems the checker did not notice the following:
find_isa_irq_apic() can return -1 /only/ if find_isa_irq_pin() returns
-1 too. So this is not a bug - it's rather a bit unclean code (and
adding a check for -1 apic does not make the code cleaner).

	Ingo 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [PATCH] implement-system-call-mini-HOWTO.txt
• Next by Date: paging request BUG in 2.6.19-rc5 on resume - X60s
• Previous by thread: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value
• Next by thread: Re: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]