Re: [PATCH 02/02] Elf: Align elf notes properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Horms <[email protected]>
Date: Mon, 13 Nov 2006 09:23:03 +0900

> On Fri, Nov 10, 2006 at 04:43:49PM -0800, David Miller wrote:
> > From: Jeremy Fitzhardinge <[email protected]>
> > Date: Fri, 10 Nov 2006 16:26:46 -0800
> > 
> > > David Miller wrote:
> > > > I think Elf64 notes very much would need 64-bit alignment, especially
> > > > if there are u64 objects in there.  Otherwise it would not be possible
> > > > to directly dereference such objects without taking unaligned faults
> > > > on several types of RISC cpus.
> > > >   
> > > 
> > > That doesn't appear to have been a problem.
> > 
> > We should be OK with the elf note header since n_namesz, n_descsz, and
> > n_type are 32-bit types even on Elf64.  But for the contents embedded
> > in the note, I am not convinced that there are no potential issues.
> 
> The interesting thing is that from my reading of the elf64 spec,
> name ends up being 32 bit alightned, and desc ends up being 64 bit
> aligned. Do you think the former could be a problem? I am thinking not
> as its always a string.

Right, it should be fine.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux