Ingo Molnar wrote:
> On Fri, 2006-11-10 at 16:55 +0300, Pavel Emelianov wrote:
>> - int ok = misrouted_irq(irq);
>> + int ok;
>> +
>> + spin_unlock(&desc->lock);
>> + ok = misrouted_irq(irq);
>> + spin_lock(&desc->lock);
>
> your fix looks reasonable to me - it's a thinko to call misrouted_irq()
> with the descriptor lock still held. (btw., how did you find it -
> lockdep spinlock debugging or NMI watchdog?)
It was NMI watchdog who reported the deadlock. With lockdep
turned on it wouldn't be caught - local_irq_enable_in_hardirq()
is nothing but a "do { } while (0)" if CONFIG_LOCKDEP=y :)
The second issue (with 2 cpus involved) was discovered
by code examining.
> Acked-by: Ingo Molnar <[email protected]>
>
> Ingo
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
