On Fri, 2006-11-10 at 11:04 +0100, Arjan van de Ven wrote:
> >
> > /*
> > * Knob to control our willingness to enable the local APIC.
> > + *
> > + * -1=force-disable, +1=force-enable
>
> mind doing 2 defines for these? Makes things more readable I suspect
Yep.
> > - return maxlvt;
> > + return APIC_INTEGRATED(GET_APIC_VERSION(v)) ? GET_APIC_MAXLVT(v) : 2;
> > }
>
> why not use lapic_is_integrated() here?
oops.
> > \
> > + if (cpu_has_tsc)
> > + apic_printk(APIC_VERBOSE, "..... CPU clock speed is "
>
> please put "approximated at" or something here; or people will call
> supportlines if they bought a 3.4Ghz processor and this shows 3.39999Ghz
:)
> > +EXPORT_SYMBOL(switch_APIC_timer_to_ipi);
>
> why is this exported at all? Modules really shouldn't be touching apic
> level details....
This is exported for ACPI to handle the C3 stops lapic hell.
tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
