Re: [PATCH 2/3] new_inode_autonum: convert filesystems to use new function

[Eric Sandeen <sandeen@sandeen.net>]

Jeff Layton wrote:
> This patch converts all in-tree filesystems that blindly use the i_ino 
> value given by new_inode to use new_inode_autonum. Also fix up a few
> other cases where i_ino might not end up being unique.

After looking at this, since you have to change all of these filesystems
anyway, I'm not sure there's a lot of value in having
new_inode_autonum(); they all previously called new_inode() and then
filled in a few fields of the new inode.  Why not just call new_inode(),
and add a call to inode->i_inum = iunique(sb, 0)?  We don't have
new_inode_autouid() or new_inode_autoatime(), why is i_ino special in
this regard?

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/