Re: DMA APIs gumble grumble

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Wed, 2006-11-08 at 11:21 +0200, Muli Ben-Yehuda wrote:
> On Wed, Nov 08, 2006 at 07:47:33PM +1100, Benjamin Herrenschmidt wrote:
> 
> > I agree, though, device_ext sucks as a name, you are welcome to propose
> > something better, I'm no good at finding names :-)
> 
> Seems a lot like `pci_sysdata' on x86-64 and i386 with Jeff's PCI
> domains support. dev_sysdata? naming is not my strong suit :-)
> 
> struct pci_sysdata {
> 	int		domain;    /* PCI domain */
> 	int		node;	   /* NUMA node */
> 	void*           iommu;	   /* IOMMU private data */
> };

Interesting... It looks a _lot_ like my device_ext :-)

The reason we don't use PCI sysdata is that currently, our PCI layer
already hijacks it with something else (ugh, I know, it sucks). I'm
pondering consolidating all of this though, but since I need that for
more than PCI, it cannot be just sysdata. Also, as I explained, I'd
prefer having it directly in struct device to avoid one more pointer
indirection in the DMA hot path.

But it looks like if we get that, x86 might be able to move their
sysdata to there.

You might be bad at naming, but I'm worse. Your dev_sysdata wins over my
device_ext imho :-)

So unless I get some better proposal, I'll do a patch introducing that
as an empty struct on all archs, possibly tonmorrow, and then start
migrating things to it.

Cheers,
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/