Re: [PATCH] pci quirks: Sort out the VIA mess once and for all (hopefully)

Alan Cox wrote:

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc4-mm1/include/linux/libata.h linux-2.6.19-rc4-mm1/include/linux/libata.h
--- linux.vanilla-2.6.19-rc4-mm1/include/linux/libata.h	2006-10-31 21:11:50.000000000 +0000
+++ linux-2.6.19-rc4-mm1/include/linux/libata.h	2006-11-07 10:07:10.000000000 +0000
@@ -109,11 +109,6 @@
 /* defines only for the constants which don't work well as enums */
 #define ATA_TAG_POISON		0xfafbfcfdU

-/* move to PCI layer? */

-#define PCI_VDEVICE(vendor, device)		\
-	PCI_VENDOR_ID_##vendor, (device),	\
-	PCI_ANY_ID, PCI_ANY_ID, 0, 0
-
 static inline struct device *pci_dev_to_dev(struct pci_dev *pdev)
 {

nit: don't remove the "move to PCI layer?" comment, it also applies to code below that which you are moving.

Patch overall seems sane to me.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] pci quirks: Sort out the VIA mess once and for all (hopefully)
    • From: Alan Cox <[email protected]>

• Prev by Date: Re: [PATCH 0/14] KVM: Kernel-based Virtual Machine (v4)
• Next by Date: [PATCH 21/33] usb: phidgetkit free urb cleanup
• Previous by thread: Re: [PATCH] pci quirks: Sort out the VIA mess once and for all (hopefully)
• Next by thread: [PATCH] sysctl: Undeprecate sys_sysctl
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]