Re: tg3_read_partno(): possible array overrun

From: "Michael Chan" <[email protected]>
Date: Mon, 06 Nov 2006 12:07:31 -0800

> On Mon, 2006-11-06 at 10:45 +0100, Adrian Bunk wrote:
> > The Coverity checker noted the following in drivers/net/tg3.c:
> > 
> > <--  snip  -->
> > 
> > The problem is that vpd_data[i + 2] could be vpd_data[255 + 2].
> 
> Thanks.  This should fix it:
> 
> [TG3]: Fix array overrun in tg3_read_partno().
> 
> Use proper upper limits for the loops and check for all error
> conditions.
> 
> The problem was noticed by Adrian Bunk.
> 
> Signed-off-by: Michael Chan <[email protected]> 

Applied, thanks Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • tg3_read_partno(): possible array overrun
    • From: Adrian Bunk <[email protected]>
  • Re: tg3_read_partno(): possible array overrun
    • From: "Michael Chan" <[email protected]>

• Prev by Date: Re: [PATCH] i386: Update MMCONFIG resource insertion to check against e820 map.
• Next by Date: Re: [PATCH 2.6.19 5/5] fs: freeze_bdev with semaphore not mutex
• Previous by thread: Re: tg3_read_partno(): possible array overrun
• Next by thread: [2.6 patch] ext4_ext_split(): remove dead code
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]