Re: [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode

• To: Hoang-Nam Nguyen <[email protected]>
• Subject: Re: [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
• From: Roland Dreier <[email protected]>
• Date: Tue, 07 Nov 2006 11:25:12 -0800
• Authentication-results: sj-dkim-4.cisco.com; [email protected]; dkim=pass ( sig from cisco.com verified; );
• Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
• Dkim-signature: a=rsa-sha1; q=dns; l=285; t=1162927513; x=1163791513; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:Roland=20Dreier=20<[email protected]> |Subject:Re=3A=20[PATCH=202.6.19=202/4]=20ehca=3A=20hcp_phyp.c=3A=20correct=20pag e=20mapping=20in=2064k=20page=20mode; X=v=3Dcisco.com=3B=20h=3DBbmXqFT3tNVlEey5aydzSYmFv7c=3D; b=G/irkHYM0oQzGAZeqEHU0N7ooAGWaKzYr7w0VSGQScZGswo7DHF4tTvlQbbhHRd5s0thrIp4 5HW98SoMGWIYA0WDS8U0gpvcuN3VFxvEyRBEUhAcQExJljpXTFOHRecP;
• In-reply-to: <[email protected]> (Hoang-Nam Nguyen's message of "Sun, 5 Nov 2006 21:41:28 +0100")
• References: <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)

 > -	*mapaddr = (u64)(ioremap(physaddr, EHCA_PAGESIZE));
 > +	*mapaddr = (u64)ioremap((physaddr & PAGE_MASK), PAGE_SIZE) +
 > +		(physaddr & (~PAGE_MASK));

I'm confused -- shouldn't ioremap() do the right thing even if
physaddr isn't page-aligned?  Why is this needed?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
    • From: Christoph Raisch <[email protected]>

• References:
  • [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
    • From: Hoang-Nam Nguyen <[email protected]>

• Prev by Date: Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices
• Next by Date: Re: [take21 0/4] kevent: Generic event handling mechanism.
• Previous by thread: [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
• Next by thread: Re: [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]