Re: [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE_SIZE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dave Kleikamp wrote:
On Tue, 2006-11-07 at 07:40 -0600, Dave Kleikamp wrote:
It would probably be best to just set stat->blksize to the negotiated
buffer size.

But be careful here.  I don't know how applications/glibc may behave if
stat->blksize is not a power of 2.
The man page is not particularly helpful either as it simply indicates:
"The st_blksize field gives the preferred blocksize for efficient file system I/O. " but it appears that blksize would affects readdir performance more than read/write
(since read/write go through the pagecache and thus readpages/writepages
will request readahead/writebehind for many pages at a time) unless the application
opens the file direct i/o.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux