At Tue, 7 Nov 2006 13:38:06 +0100,
Adrian Bunk wrote:
>
> On Tue, Nov 07, 2006 at 11:43:48AM +0100, Takashi Iwai wrote:
> > At Mon, 6 Nov 2006 19:30:18 +0100,
> > Adrian Bunk wrote:
> > >
> > > This patch removes some obviously dead code spotted by the Coverity
> > > checker.
> > >
> > > Signed-off-by: Adrian Bunk <[email protected]>
> >
> > I think it's a wrong fix. result could be > 0 indeed.
> >
> > Takashi
> >
> > >
> > > --- linux-2.6/sound/core/control.c.old 2006-11-06 19:11:32.000000000 +0100
> > > +++ linux-2.6/sound/core/control.c 2006-11-06 19:11:52.000000000 +0100
> > > @@ -1267,23 +1267,23 @@ static ssize_t snd_ctl_read(struct file
> > > if ((file->f_flags & O_NONBLOCK) != 0 || result > 0) {
>
> That is already checked here -> ^^^^^^^^^^
>
> And after this point, result is never assigned any value.
Ah, I see. Now applied it to ALSA tree.
Thanks.
Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
