Re: [PATCH 2.6.19-rc4] usb urb unlink/free clenup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, 

> > We do not need to check for urb != NULL before we call them.
> 
> Seems reasonable.
> 
> Your patch had all its tabs replaced with spaces by your email client.  I
> fixed that all up, but it was rather dull work and I'd prefer not to have
> to do it again.

Will investigate - hopefully won't happen again. Sorry.

> > Or maybe there is no need for this?
> > 
> 
> I think it's OK as-is.  Presumably it's rare for a caller to pass in a NULL
> urb.
> 
> It's possible that your proposed change will cause new (and incorrect)
> warnings to be emitted, but we can handle those if/when they come out.

Ok here is the dumb part. Do I send the next diff against the work I already did?

Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux