Re: 2.6.19 Microcode Update causes a ten second wait

[Arjan van de Ven <arjan@infradead.org>]

On Mon, 2006-11-06 at 21:33 +0000, Andrew Benton wrote:
> Hello World
> With the 2.6.19 kernels I've tried (2.6.19-rc1-git7 and 
> 2.6.19-rc4-git10), enabling the Intel Microcode Update Driver causes the 
> kernel to hang for more than ten seconds when I boot. The last thing it 
> shows on the screen is `TCP reno registered' and then it just stops like 
> its a kernel panic. But it isn't, after about ten seconds the text flies 
> up the screen again and the system boots normally. Disabling support for 
> the microcode update makes the problem go away.

you're lucky, for me it hangs forever until I add this patch:

--- linux-2.6.18/arch/i386/kernel/microcode.c.org	2006-11-06 14:50:37.000000000 +0100
+++ linux-2.6.18/arch/i386/kernel/microcode.c	2006-11-06 14:52:30.000000000 +0100
@@ -577,7 +577,7 @@ static void microcode_init_cpu(int cpu)
 	set_cpus_allowed(current, cpumask_of_cpu(cpu));
 	mutex_lock(&microcode_mutex);
 	collect_cpu_info(cpu);
-	if (uci->valid)
+	if (uci->valid && system_state==SYSTEM_RUNNING)
 		cpu_request_microcode(cpu);
 	mutex_unlock(&microcode_mutex);
 	set_cpus_allowed(current, old);


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/