Re: [PATCH 6/12] repost: cciss: set sector_size to 2048 for performance

On Mon, Nov 06 2006, Mike Miller (OS Dev) wrote:
> PATCH 6/11
> 
> This patch changes the blk_queue_max_sectors from 512 to 2048. This helps
> increase performance.
> Please consider this for inclusion.

Bad naming - I've never seen sector size refer to anything else but the
actual sector size on the device. Here you use it as the largest
supported command size. To make matters worse, you also export it in the
proc file as such, that's certain to confuse users.

In other news, ack on patch 1-5 so far.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 6/12] repost: cciss: set sector_size to 2048 for performance
    • From: "Mike Miller (OS Dev)" <[email protected]>

• Prev by Date: [PATCH 9/12] repost: cciss: add busy_configuring flag
• Next by Date: [PATCH 10/12] repost: cciss: add support for 1024 logical volumes
• Previous by thread: [PATCH 6/12] repost: cciss: set sector_size to 2048 for performance
• Next by thread: [PATCH 7/12] repost: cciss: change cciss_open for consistency
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]