Re: [PATCH] airo.c: check returned values

Florin Malita wrote:

create_proc_entry() can fail and return NULL in setup_proc_entry(), the
result must be checked before dereferencing. (Coverity ID 1443)

init_wifidev() & setup_proc_entry() can also fail in _init_airo_card().

This adds the checks & cleanup code and removes some whitespace.

Signed-off-by: Florin Malita <[email protected]>

NAK: create_proc_entry() is complicated. You are correct it can fail -- but to add to the confusion, when CONFIG_PROC_FS is disabled, the wrapper will also return NULL -- which is NOT a failure case.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] airo.c: check returned values
    • From: Florin Malita <[email protected]>

• References:
  • [PATCH] airo.c: check returned values
    • From: Florin Malita <[email protected]>

• Prev by Date: Re: [PATCH] e1000: Fix regression: garbled stats and irq allocation during swsusp
• Next by Date: Re: ZONE_NORMAL memory exhausted by 4000 TCP sockets
• Previous by thread: [PATCH] airo.c: check returned values
• Next by thread: Re: [PATCH] airo.c: check returned values
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]