Re: [PATCH 30/61] knfsd: Fix race that can disable NFS server.

[Neil Brown <neilb@suse.de>]

On Saturday November 4, w@1wt.eu wrote:
> Hi Neil, 
> 
> I don't know if you noticed my request for ACK as I did not get any
> response. I think that your patch here is a good candidate for 2.4
> too, I would just like to get your confirmation before merging it.

Sorry, I went to grab a copy of the latest 2.4 to double-check and the
got distracted.

Yes: this patch is definitely appropriate for 2.4.

Thanks,
NeilBrown

> > ---
> >  net/sunrpc/svcsock.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2.6.18.1.orig/net/sunrpc/svcsock.c
> > +++ linux-2.6.18.1/net/sunrpc/svcsock.c
> > @@ -902,7 +902,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
> >  		return 0;
> >  	}
> >  
> > -	if (test_bit(SK_CONN, &svsk->sk_flags)) {
> > +	if (svsk->sk_sk->sk_state == TCP_LISTEN) {
> >  		svc_tcp_accept(svsk);
> >  		svc_sock_received(svsk);
> >  		return 0;
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/