Re: [PATCH 1/2] sunrpc: add missing spin_unlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2006-11-05 at 11:45 -0800, Andrew Morton wrote:
> On Sun, 05 Nov 2006 17:35:16 +0100
> Peter Zijlstra <[email protected]> wrote:
> 
> > On Sun, 2006-10-29 at 22:37 +0900, Akinobu Mita wrote:
> > > auth_domain_put() forgot to unlock acquired spinlock.
> > > 
> > > Cc: Olaf Kirch <[email protected]>
> > > Cc: Andy Adamson <[email protected]>
> > > Cc: J. Bruce Fields <[email protected]>
> > > Cc: Trond Myklebust <[email protected]>
> > > Signed-off-by: Akinobu Mita <[email protected]>
> > 
> > Acked-by: Peter Zijlstra <[email protected]>
> > 
> > I just found this too while trying to get .19-rc4-git up and running on
> > a machine here - took me a few hours.
> > 
> > It made my kernel decidedly unhappy :-(
> > 
> > Andrew, could you push this and:
> >   http://lkml.org/lkml/2006/11/3/109
> > into .19 still? - those patches are needed to make todays git happy on
> > my machine.
> 
> OK.

Thanks!

> I wonder if this will fix http://bugzilla.kernel.org/show_bug.cgi?id=7457

The scheduling while atomic part looks familiar, the rest not so.

Worth giving it a shot though...

On my machine it was the keventd workqueue that got messed up.
I have some patches that:
 - add debug_show_held_locks(current) to might_sleep() and schedule()
 - check in_atomic() and lockdep_depth after each workqueue function
   and print the last function executed
 - name some 'old_style_spin_init' locks

I'll post those patches after a cleanup...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux