On Sat, 2006-11-04 at 18:36 +0100, Arjan van de Ven wrote:
> On Fri, 2006-11-03 at 14:00 -0500, Luugi Marsan wrote:
> > From: [email protected]
> >
> > There was an ASIC bug in the SB600 SATA controller of low revision (<=13) and CD burning may hang (only SATA ODD has this issue, and SATA HDD works well). The patch provides a workaround for this issue.
> >
> > Signed-off-by: Luugi Marsan <[email protected]>
> >
> > --- linux-2.6.19-rc4-git5/drivers/ata/ahci.c.orig 2006-11-04 03:56:22.000000000 +0800
> > +++ linux-2.6.19-rc4-git5/drivers/ata/ahci.c 2006-11-04 04:20:36.000000000 +0800
> > @@ -189,6 +189,7 @@ struct ahci_host_priv {
> > unsigned long flags;
> > u32 cap; /* cache of HOST_CAP register */
> > u32 port_map; /* cache of HOST_PORTS_IMPL reg */
> > + u8 rev; /* PCI Revision ID */
> > };
> >
>
> why put this into the ahci struct rather than in the pci device struct?
> In the place you use it you already have the pci device struct already..
> and it's really a pci device property so putting it in that struct makes
> a whole lot of sense conceptually anyway...
>
>
Hi Arjan,
Yes, I also thought it's more reasonable to add "u8 rev;" to pci_dev
than to ahci_host_priv, but that will effect source code in large scope,
so I added it here :(
Maybe I should resend a patch both for pci_dev and SB600 SATA at the
same time.
Best regards,
Conke Hu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
