Re: [PATCH 1/2] Add Legacy IDE mode support for SB600 SATA

[Conke Hu <conke.hu@amd.com>]

On Fri, 2006-11-03 at 19:30 +0000, Alan Cox wrote:
> Ar Gwe, 2006-11-03 am 13:54 -0500, ysgrifennodd Luugi Marsan:
> > From: conke.hu@amd.com
> > 
> > ATI SB600 SATA controller supports 4 modes: Legacy IDE, Native IDE, AHCI and RAID.IDE modes are used for compatibility with some old OS without AHCI driver,but now they are not necessary for Linux since the kernel has supported AHCI.Some BIOS set Legacy IDE as SB600 SATA's default mode, but the AHCI driver cannot run in Legacy IDE.So, we should set the controller back to AHCI mode if it has been set as IDE by BIOS.
> > 
> > Signed-off-by:  Luugi Marsan <luugi.marsan@amd.com>
> 
> NAK
> 
> This should only be done if AHCI is configured into the kernel, so wants
> a #ifdef check adding. Otherwise people using SB600 via the legacy ide
> layer will get burned.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 

Hi Alan,
    Thank you for your consideration and reply. But there seems to be
some misunderstanding.

    1. The SATA configuration option "Legacy IDE mode" (as well as
Native IDE mode) in SB600 BIOS is ONLY for old OS, and it is not useful
any longer for new Linux kernels.

    2. We could consider:
       original system BIOS + this patch == new BIOS for Linux.
    (This will not effect any other OS installed or to be installed on
SB600.)

    3. "This should only be done if AHCI is configured into the kernel,
so wants a #ifdef check adding".
    Alan, this fix should always be done whether AHCI is configured into
kernel or not, even when AHCI is not configured at all. Because:
    a). Without it, the SB600 SATA controller will appear as an IDE,
which may misguide user to try to load legacy IDE driver (or other IDE
driver). For example, if user run command "lspci" he will consider the
controller as an IDE by mistake and maybe he will try to load legacy IDE
driver (or other IDE driver).
    b). We have a RAID driver (close source) for SB600 SATA which does
not depends on the open source AHCI driver in linux kernel and supports
both AHCI and RAID. But if the controller is configured as legacy IDE by
BIOS, the RAID driver cannot run at all because of the IRQ policy. 

    4. "Otherwise people using SB600 via the legacy ide layer will get
burned." 
    Why? After kernel is fixed by this patch, is there still any legacy
ide layer or ide driver that will touch SB600 SATA controller? (the
class code has been changed to 0x010601, which tells the kernel, "I am
an AHCI 1.0 controller, not an IDE".)
   


Best regards,
Conke Hu

    

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/