[Argh. Kaum ist man mal ein paar Tage weg ...]
Am 28.10.2006 20:45 schrieb Akinobu Mita:
> --- work-fault-inject.orig/drivers/isdn/gigaset/common.c
> +++ work-fault-inject/drivers/isdn/gigaset/common.c
> @@ -579,7 +579,7 @@ static struct bc_state *gigaset_initbcs(
> } else if ((bcs->skb = dev_alloc_skb(SBUFSIZE + HW_HDR_LEN)) != NULL)
> skb_reserve(bcs->skb, HW_HDR_LEN);
> else {
> - dev_warn(cs->dev, "could not allocate skb\n");
> + gig_dbg(DEBUG_INIT, "could not allocate skb\n");
> bcs->inputstate |= INS_skip_frame;
> }
I'm not quite happy with that patch. (Nor, for that matter, with the
speed it was pushed into mainline, without waiting even a few days
for comments from the maintainers of the code in question.)
Not being able to allocate that skb seriously impairs functionality
of the driver. It should be reported on production systems too, not
just on debug builds.
In short: NAK. Please revert, and replace by the following:
From: Tilman Schmidt <[email protected]>
Avoid usage of uninitialized cs->dev in gigaset_initbcs().
Signed-off-by: Tilman Schmidt <[email protected]>
Cc: Hansjoerg Lipp <[email protected]>
Cc: Karsten Keil <[email protected]>
Cc: Kai Germaschewski <[email protected]>
Cc: Akinobu Mita <[email protected]>
Cc: Andrew Morton <[email protected]>
---
drivers/isdn/gigaset/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/isdn/gigaset/common.c
+++ b/drivers/isdn/gigaset/common.c
@@ -616,7 +616,7 @@ static struct bc_state *gigaset_initbcs(
} else if ((bcs->skb = dev_alloc_skb(SBUFSIZE + HW_HDR_LEN)) != NULL)
skb_reserve(bcs->skb, HW_HDR_LEN);
else {
- dev_warn(cs->dev, "could not allocate skb\n");
+ warn("could not allocate skb");
bcs->inputstate |= INS_skip_frame;
}
--
Tilman Schmidt E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeoeffnet mindestens haltbar bis: (siehe Rueckseite)
Attachment:
signature.asc
Description: OpenPGP digital signature
- References:
- [PATCH] isdn/gigaset: avoid cs->dev null pointer dereference
- From: Akinobu Mita <[email protected]>
- [PATCH] isdn/gigaset: avoid cs->dev null pointer dereference
- Prev by Date: Re: New filesystem for Linux
- Next by Date: Re: async I/O seems to be blocking on 2.6.15
- Previous by thread: [PATCH] isdn/gigaset: avoid cs->dev null pointer dereference
- Next by thread: [PATCH] paride: return proper error code
- Index(es):
 |