On Thu, Nov 02, 2006 at 01:14:43PM -0800, Andrew Morton wrote:
> What is a "hose"?
A real name of "pci domain". ;-)
> > + /* First, fixup the VGA resource bounds WRT the hose it is on. */
> > + if (pci_vga_hose) {
> > + new->start += pci_vga_hose->io_space->start;
> > + new->end += pci_vga_hose->io_space->start;
> > + }
> > +
> > + /* Finally, do a normal request_resource(). */
> > + return request_resource(root, new);
This will always fail. Should be
return request_resource(pci_vga_hose->io_space, new);
> > +}
> >
>
> So if the resource is being requested by vga we adjust the caller's
> resource before actually requesting it.
>
> Isn't this a bit hacky? How come vgacon ended up requesting the wrong
> addresses in the first place?
vgacon requests the correct _bus_ address, but it doesn't work with
multiple buses. So a fixup similar to pcibios_fixup_resource() or
pcibios_bus_to_resource() is needed.
Ivan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
